Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Fix PDF fallback #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leonardosfl
Copy link
Contributor

preprintId should be used in the docId attribute, just like here: https://github.com/prereview/rapid-prereview/blob/16e9bfe7ca522edab2bfb4f85b855d37b33313a5/src/components/extension-fallback.js#L67-L68

This was causing an error since the preprintId parameter was incorrect.

a
b

I also noticed that the fallback PDF is always being fetched, even if it's not used. Not sure if this is a bug.
c

According to this line of code, it should be a fallback, right?
https://github.com/prereview/rapid-prereview/blob/16e9bfe7ca522edab2bfb4f85b855d37b33313a5/src/components/extension-fallback.js#L79

@georgiamoon georgiamoon requested a review from dwins July 28, 2020 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant